Skip to content

fix(facts): use vertical m for submarine rangefinder distance facts#14620

Open
Bartok9 wants to merge 4 commits into
mavlink:masterfrom
Bartok9:aerial/submarine-rf-vertical-m-2026-07-17
Open

fix(facts): use vertical m for submarine rangefinder distance facts#14620
Bartok9 wants to merge 4 commits into
mavlink:masterfrom
Bartok9:aerial/submarine-rf-vertical-m-2026-07-17

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set SubmarineFact rangefinderDistance and rangefinderTarget units to vertical m.

Motivation

ROV rangefinder range/target are vertical-axis lengths. Plain m skips Vertical Distance unit conversion.

Verification

  • JSON OK; two unit fields only
  • No vehicle control changes

Notes

AI-assisted; human-reviewed. Complements prior vertical-m fact work (DonLakeFlyer coalesce credited earlier merges).

@codecov

codecov Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.58%. Comparing base (f29efd3) to head (c7c7473).
⚠️ Report is 156 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14620      +/-   ##
==========================================
+ Coverage   25.47%   31.58%   +6.11%     
==========================================
  Files         769      785      +16     
  Lines       65912    66985    +1073     
  Branches    30495    31029     +534     
==========================================
+ Hits        16788    21159    +4371     
+ Misses      37285    31443    -5842     
- Partials    11839    14383    +2544
Flag Coverage Δ
unittests 31.58% <ø> (+6.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 455 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6487625...c7c7473. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 33 passed, 0 skipped
linux-coverage-unit: 107 passed, 0 skipped
Total: 140 passed, 0 skipped

Code Coverage

Coverage: 67.8%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.89 MB
QGroundControl-aarch64 179.42 MB
QGroundControl-installer-AMD64 137.93 MB
QGroundControl-installer-AMD64-ARM64 80.45 MB
QGroundControl-installer-ARM64 109.22 MB
QGroundControl-linux 87.10 MB
QGroundControl-mac 87.09 MB
QGroundControl-windows 86.16 MB
QGroundControl-x86_64 191.65 MB
No baseline available for comparison

Updated: 2026-07-19 13:14:54 UTC • Commit: c7c7473 • Triggered by: Android

@Bartok9
Bartok9 force-pushed the aerial/submarine-rf-vertical-m-2026-07-17 branch from 82bb408 to 8f52999 Compare July 17, 2026 20:23
@Bartok9
fix(facts): use vertical m for submarine rangefinder distance facts
e5537a4 
Rangefinder range and target are vertical-axis lengths for ROV displays.
Plain "m" skips Vertical Distance unit preference conversion.
@Bartok9
Bartok9 force-pushed the aerial/submarine-rf-vertical-m-2026-07-17 branch from 8f52999 to e5537a4 Compare July 18, 2026 20:28
@Bartok9 Bartok9 mentioned this pull request Jul 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Bartok9